Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Round 2: Magic block for modules

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Round 2: Magic block for modules
Date: 2006-05-30 14:09:31
Message-ID: 200605301409.k4UE9Vw17939@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------


Martijn van Oosterhout wrote:
-- Start of PGP signed section.
> Per feedback, here is an updated version. As was pointed out, the prior
> version was checking stuff that either changed too often to be useful
> or was never going to change at all. The error reporting is cleaned up
> too, it now releases the module before throwing the error. It now only
> checks four things:
> 
> Major version number (7.4 or 8.1 for example)
> NAMEDATALEN
> FUNC_MAX_ARGS
> INDEX_MAX_KEYS
> 
> The three constants were chosen because:
> 
> 1. We document them in the config page in the docs
> 2. We mark them as changable in pg_config_manual.h
> 3. Changing any of these will break some of the more popular modules:
> 
> FUNC_MAX_ARGS changes fmgr interface, every module uses this
> NAMEDATALEN changes syscache interface, every PL as well as tsearch uses this
> INDEX_MAX_KEYS breaks tsearch and anything using GiST.
> 
> I considered others but ultimatly rejected them. For example,
> HAVE_INT64_TIMESTAMP, while changing the way timestamps are stored and
> being configurable by a configure option, doesn't actually break
> anything important (only the btree_gist example in contrib).
> 
> Any more comments?
> 
> Have a nice day,
> -- 
> Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> > From each according to his ability. To each according to his ability to litigate.

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2006-05-30 14:13:00
Subject: Re: PL/PGSQL: Dynamic Record Introspection
Previous:From: Bruce MomjianDate: 2006-05-30 14:08:18
Subject: Re: Proposed doc-patch: Identifying the Current WAL file

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group