Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Round 2: Magic block for modules

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Round 2: Magic block for modules
Date: 2006-05-30 20:14:09
Message-ID: 17221.1149020049@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Patch applied.  Thanks.

I hadn't gotten around to reviewing the revised version.  Just to let
you know, I'm going to remove the separate header file pgmagic.h and
put the macro into fmgr.h as I'd suggested originally.  The reason is
that the separate file turns the problem of making backward-compatible
modules from a simple "#ifdef PG_MAGIC_BLOCK" into a big does-that-
header-exist autoconf pushup.  It's not worth that.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2006-05-30 20:19:59
Subject: Re: [PATCH] Round 2: Magic block for modules
Previous:From: Neil ConwayDate: 2006-05-30 18:10:57
Subject: Re: PL/PGSQL: Dynamic Record Introspection

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group