Skip site navigation (1) Skip section navigation (2)

Re: Error in recent pg_dump change (coverity)

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Error in recent pg_dump change (coverity)
Date: 2006-05-28 16:01:11
Message-ID: 20060528160111.GB22869@svana.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sun, May 28, 2006 at 11:42:48AM -0400, Alvaro Herrera wrote:
> Martijn van Oosterhout wrote:
> > I'd actually suggest zeroing out res->tuples in PQclear so this sort of
> > problem becomes much more obvious.
> 
> Is it worthwhile to zero out the res->block array as well?

Patch is good, but setting block to NULL is a waste of time, it's not
global. And I think res->curBlock is automatically set NULL as result
of the loop...

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

pgsql-hackers by date

Next:From: Martijn van OosterhoutDate: 2006-05-28 16:13:34
Subject: Re: Error in recent pg_dump change (coverity)
Previous:From: Tom LaneDate: 2006-05-28 16:00:33
Subject: Re: Error in recent pg_dump change (coverity)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group