| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Error in recent pg_dump change (coverity) |
| Date: | 2006-05-28 15:42:48 |
| Message-ID: | 20060528154248.GA11881@surnet.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martijn van Oosterhout wrote:
> Coverity picked up an error in dumpStdStrings() since last night. At
> line 1448 there's PQclear(res) yet it's used several times further down
> (lines 1452, 1454 and 1456).
>
> I'd actually suggest zeroing out res->tuples in PQclear so this sort of
> problem becomes much more obvious.
Is it worthwhile to zero out the res->block array as well?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| Attachment | Content-Type | Size |
|---|---|---|
| coverity-304.patch | text/plain | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-05-28 15:42:51 | Re: osprey buildfarm member has been failing for a long while |
| Previous Message | Martijn van Oosterhout | 2006-05-28 12:32:04 | Error in recent pg_dump change (coverity) |