Skip site navigation (1) Skip section navigation (2)

Re: Error in recent pg_dump change (coverity)

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Error in recent pg_dump change (coverity)
Date: 2006-05-28 15:42:48
Message-ID: 20060528154248.GA11881@surnet.cl (view raw or flat)
Thread:
Lists: pgsql-hackers
Martijn van Oosterhout wrote:
> Coverity picked up an error in dumpStdStrings() since last night. At
> line 1448 there's PQclear(res) yet it's used several times further down
> (lines 1452, 1454 and 1456).
> 
> I'd actually suggest zeroing out res->tuples in PQclear so this sort of
> problem becomes much more obvious.

Is it worthwhile to zero out the res->block array as well?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-05-28 15:42:51
Subject: Re: osprey buildfarm member has been failing for a long while
Previous:From: Martijn van OosterhoutDate: 2006-05-28 12:32:04
Subject: Error in recent pg_dump change (coverity)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group