Re: Duplicate definition of LOCALEDIR

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Duplicate definition of LOCALEDIR
Date: 2006-05-22 12:39:04
Message-ID: 20060522123904.GD24404@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, May 22, 2006 at 12:17:33PM +0200, Peter Eisentraut wrote:
> LOCALEDIR is defined in
>
> src/port/pg_config_paths.h
> src/include/pg_config.h
>
> but one of them should be enough. (May be dependent on --enable-nls.) Which
> one should be removed?

I'd suggest the version in pg_config. Both are ultimatly generated by
configure, but LOCALEDIR is the only directory definition that appears
in pg_config.h.

The fix is simple: remove the AC_DEFINE_UNQUOTED(LOCALEDIR, ...) from
programs/config.h. localedir is still defined.

The odd thing is that there are two paths defined, $localedir and
$exp_localedir, which are not the same and pg_config.h gets one and
pg_config_paths.h gets the other.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-05-22 14:41:20 Re: SSL certificate info on SQL level and HSM support for libpq
Previous Message Mark Woodward 2006-05-22 11:47:56 Re: String Similarity

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-05-22 14:52:04 Re: trivial fix in fd.c
Previous Message Peter Eisentraut 2006-05-22 10:17:33 Duplicate definition of LOCALEDIR