| From: | jwp(at)pgfoundry(dot)org (James William Pye) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | python - fe: Don't close the connection on __del__. |
| Date: | 2006-03-30 15:42:19 |
| Message-ID: | 20060330154219.7FEE31033846@pgfoundry.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Don't close the connection on __del__.
While convenient, this is potentially undesireable. In particular, I imagine
there may be cases where it is desireable to pass around internals of already
established connections; Interchange or the Interchange's pipe. Additionally, it
requires more state checking for appropriate cleanup in certain
situations. For instance, socket errors on connection instantiation may cause
an attribute error to be thrown in __del__.
Modified Files:
--------------
fe/src:
tracenull.py (r1.20 -> r1.21)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/fe/src/tracenull.py.diff?r1=1.20&r2=1.21)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-03-30 22:11:55 | pgsql: Suppress attempts to report dropped tables to the stats collector |
| Previous Message | User Ksrikanth | 2006-03-30 06:53:37 | bizgres - bizgres: Fixing Version Put Postgres at the begining. |