| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Mark Dilger <pgsql(at)markdilger(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: not checking value returned from palloc? |
| Date: | 2006-03-19 22:10:22 |
| Message-ID: | 20060319221022.GA5357@surnet.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mark Dilger wrote:
> Peter Eisentraut wrote:
> >Mark Dilger wrote:
> >
> >>Looking through the postgresql source code, I notice that there are
> >>many places were palloc is used but the return value is not checked
> >>to see if it is null.
> >
> >palloc will throw an exception if it cannot fulfill the request. Code
> >that checks the return value for null is in fact a waste.
>
> Interesting. So the patch should go the other way, and remove the checks
> that are currently in the code?
Yes, if you find any such place please submit a patch.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-03-19 22:14:33 | Re: not checking value returned from palloc? |
| Previous Message | Mark Dilger | 2006-03-19 22:03:24 | Re: not checking value returned from palloc? |