Re: [HACKERS] how solve diff of API counstruct_md_array between

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Joe Conway <mail(at)joeconway(dot)com>, Pavel Stehule <pavel(dot)stehule(at)hotmail(dot)com>
Subject: Re: [HACKERS] how solve diff of API counstruct_md_array between
Date: 2006-02-28 17:28:45
Message-ID: 200602281728.k1SHSjs19643@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > Martijn van Oosterhout wrote:
> > -- Start of PGP signed section.
> >
> > > On Tue, Feb 28, 2006 at 12:45:18AM -0500, Bruce Momjian wrote:
> > > > I have developed a patch which creates a new pg_config.h define
> > > > called PG_VERSION_NUM, which is a number like 80200, with no
> > > > beta/devel designation. I think this will be helpful
> > > > (eventually) for people writing plug-ins. Attached.
> > >
> > > I like it. Arguably the development period between 8.1 and 8.2
> > > could be designated 80190 (8.1.90) with various betas being
> > > 80191-80199. But hey, having any symbol define the current version
> > > is better than nothing at all.
> > >
> > > Thanks for this,
> > > --
> > > Martijn van Oosterhout <kleptog(at)svana(dot)org>
> > > http://svana.org/kleptog/
> > >
> > > > Patent. n. Genius is 5% inspiration and 95% perspiration. A
> > > > patent is a tool for doing 5% of the work and then sitting around
> > > > waiting for someone else to do the other 95% so you can sue them.
> >
> > OK, updated version of the patch attached and applied.
>
> I still object to this. What is wrong with using the catalog version
> number?

It is pretty obscure to use a date stamp like that, rather than a number
just like PQserverVersion(). Also, it gives minor version information
that the catalog version does not.

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-02-28 17:30:46 Re: [HACKERS] how solve diff of API counstruct_md_array between
Previous Message Tom Lane 2006-02-28 17:25:27 Re: Dead Space Map

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-02-28 17:30:46 Re: [HACKERS] how solve diff of API counstruct_md_array between
Previous Message Peter Eisentraut 2006-02-28 17:19:48 Re: [HACKERS] how solve diff of API counstruct_md_array between