From: | Joachim Wieland <joe(at)mcknight(dot)de> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: psql tab completion enhancements |
Date: | 2006-02-03 20:26:48 |
Message-ID: | 20060203202648.GA5103@mcknight.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Fri, Feb 03, 2006 at 01:59:19PM -0500, Bruce Momjian wrote:
> I will adjust this patch based on later feedback emails.
I have another version of the patch. Minor style errors are corrected in it.
As far as I can see, open items are:
- Should all the
const char* foocompletion = { "BAR", "BAZ" };
be changed to
char* foocompletion = { "BAR", "BAZ" };
(including all functions that deal with that and take const char*'s now)
or should a cast be used only for the growable-list-case.
- is the simple list_add_item() algorithm sufficient for the psql use case
or not?
I append the version of the patch that I think is the latest I have.
Joachim
Attachment | Content-Type | Size |
---|---|---|
pg_tabcomplete_lists.reworked.1.diff | text/plain | 6.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Woodward | 2006-02-03 20:28:54 | Re: Multiple logical databases |
Previous Message | Mark Woodward | 2006-02-03 20:26:29 | Re: Multiple logical databases |