Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ...

From: David Fetter <david(at)fetter(dot)org>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ...
Date: 2006-01-30 06:47:13
Message-ID: 20060130064712.GA6212@fetter.org (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
On Sun, Jan 29, 2006 at 10:20:47PM -0500, Neil Conway wrote:
> On Sun, 2006-01-29 at 17:03 -0800, David Fetter wrote:
> > Another followup, this time with the comment done right.
> 
> +       /* Disallow the forbidden_delimiter strings */
> +       if (strcspn(cstate->delim, BADCHARS) != 1)
> +               elog(ERROR, "COPY delimiter cannot be %#02x",
> +                        *cstate->delim);
> + 
> 
> The comment is still wrong: referencing "forbidden_delimiter" makes
> it sound like there is something named forbidden_delimiter, but
> there is not (at least in the patch as submitted).
> 
> The patch should also use ereport rather than elog, because this
> error message might reasonably be encountered by the user.

Patch with BADCHARS attached :)

Cheers,
D
-- 
David Fetter david(at)fetter(dot)org http://fetter.org/
phone: +1 415 235 3778

Remember to vote!

In response to

Responses

pgsql-bugs by date

Next:From: dueydueyDate: 2006-01-30 10:33:35
Subject: BUG #2223: Misleading info in docs on volatility level of functions
Previous:From: Michael FuhrDate: 2006-01-30 05:16:27
Subject: Re: BUG #2217: serial in rule and trigger

pgsql-patches by date

Next:From: Thomas HallgrenDate: 2006-01-30 09:25:39
Subject: Re: Want to add to contrib.... xmldbx
Previous:From: Josh BerkusDate: 2006-01-30 05:53:21
Subject: Re: Want to add to contrib.... xmldbx

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group