pgsql: Fix longstanding bug that would sometimes let the planner

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix longstanding bug that would sometimes let the planner
Date: 2005-10-25 20:30:37
Message-ID: 20051025203037.18053D6EE1@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix longstanding bug that would sometimes let the planner generate a bad plan
for an outer join; symptom is bogus error "RIGHT JOIN is only supported with
merge-joinable join conditions". Problem was that select_mergejoin_clauses
did its tests in the wrong order. We need to force left join not right join
for a merge join when there are non-mergeable join clauses; but the test for
this only accounted for mergejoinability of the clause operator, and not
whether the left and right Vars were of the proper relations. Per report
from Jean-Pierre Pelletier.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
pgsql/src/backend/optimizer/path:
joinpath.c (r1.91.4.2 -> r1.91.4.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/joinpath.c.diff?r1=1.91.4.2&r2=1.91.4.3)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-10-25 20:30:46 pgsql: Fix longstanding bug that would sometimes let the planner
Previous Message Tom Lane 2005-10-25 20:30:31 pgsql: Fix longstanding bug that would sometimes let the planner