pgsql: [ Patch to 7.4.X.] In several places PL/Python was calling

From: momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: [ Patch to 7.4.X.] In several places PL/Python was calling
Date: 2005-09-25 03:18:17
Message-ID: 20050925031817.46419D9513@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
[ Patch to 7.4.X.]

In several places PL/Python was calling PyObject_Str() and then
PyString_AsString() without checking if the former had returned
NULL to indicate an error. PyString_AsString() doesn't expect a
NULL argument, so passing one causes a segmentation fault. This
patch adds checks for NULL and raises errors via PLy_elog(), which
prints details of the underlying Python exception. The patch also
adds regression tests for these checks. All tests pass on my
Solaris 9 box running HEAD and Python 2.4.1.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
pgsql/src/pl/plpython:
plpython.c (r1.41.2.1 -> r1.41.2.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c.diff?r1=1.41.2.1&r2=1.41.2.2)

Browse pgsql-committers by date

  From Date Subject
Next Message User Andrewd 2005-09-25 14:39:10 pgbuildfarm - client-code: Clean up anything left lying around by
Previous Message Bruce Momjian 2005-09-25 03:12:17 pgsql: Wording cleanup.