Re: Adding a new node to the executor

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Varun Kacholia <kacholia(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Adding a new node to the executor
Date: 2005-09-03 14:48:00
Message-ID: 200509031448.j83Em0111257@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> On Sat, Sep 03, 2005 at 02:43:20AM -0700, Varun Kacholia wrote:
>
> > But the RangeTblEntry received by my executor node does
> > not have the tablesample set, inspite of the fact that I do set it in
> > parse_relation.c:addRangeTableEntry().
> >
> > I have made the appropriate changes to copyfuncs.c, but still in vain..
>
> Did you change all the other files in src/backend/nodes? You need to
> change not only copyfuncs.c, but equalfuncs, outfuncs and readfuncs as
> well.

Yep. My suggestion is to pick an existing field in RangeTblEntry and
find all occurances of that, and determine if your new field has to be
added in that place.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2005-09-03 15:08:22 core dump with last CVS
Previous Message Bruce Momjian 2005-09-03 14:46:08 Re: Remove xmin and cmin from frozen tuples