Re: [HACKERS] For review: Server instrumentation patch

Andreas Pflug wrote:
> Bruce Momjian wrote:
>
> >
> >
> > I don't assume people using psql will care about the current log files ---
>
> Hm. Probably because you think these users will have direct file access?
> Which in turn means they can edit *.conf directly too and don't need an
> interface for that either.

I don't see how listing the log files relates to editing the confuration
files.

> > it would be something done in C or another application language. Aren't
> > the file names already ordered based on their file names, given the
> > default pattern, postgresql-%Y-%m-%d_%H%M%S.log?
>
> The issue is _filtering_, not ordering. Since the log directory might be
> directed to a different location, non-pgsql logfiles might be there too.
> You'd probably won't expect to retrieve these files over a pgsql connection.

Well, if they mix log files and non-log files in the same directory, we
would have to filter based on the log_filename directive in the
application, or use LIKE in a query.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073