More buildfarm stuff

From: "Jim C(dot) Nasby" <decibel(at)decibel(dot)org>
To: pgsql-hackers(at)postgresql(dot)org, girgen(at)FreeBSD(dot)org
Subject: More buildfarm stuff
Date: 2005-07-19 18:54:07
Message-ID: 20050719185407.GV38511@decibel.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

http://archives.postgresql.org/pgsql-bugs/2005-07/msg00096.php describes
what I think is causing octopus to fail. What's also interesting is
these patches from the FreeBSD port:

decibel(at)flake(dot)2[13:48]/usr/ports/databases/postgresql80-server/files:37>cat patch-plpython-Makefile patch-src-makefiles-Makefile.freebsd
--- src/pl/plpython/Makefile.orig Fri Nov 19 20:23:01 2004
+++ src/pl/plpython/Makefile Tue Dec 28 23:32:16 2004
@@ -9,7 +9,7 @@
# shared library. Since there is no official way to determine this
# (at least not in pre-2.3 Python), we see if there is a file that is
# named like a shared library.
-ifneq (,$(wildcard $(python_libdir)/libpython*$(DLSUFFIX)*))
+ifneq (,$(wildcard $(python_libdir)/../../libpython*$(DLSUFFIX)*))
shared_libpython = yes
endif

--- src/makefiles/Makefile.freebsd.orig Fri Nov 19 01:41:39 2004
+++ src/makefiles/Makefile.freebsd Tue Dec 21 02:44:09 2004
@@ -11,7 +11,7 @@
ifeq ($(findstring sparc,$(host_cpu)), sparc)
CFLAGS_SL = -fPIC -DPIC
else
-CFLAGS_SL = -fpic -DPIC
+CFLAGS_SL = -fPIC -DPIC
endif


@@ -29,3 +29,5 @@
endif

sqlmansect = 7
+
+allow_nonpic_in_shlib = yes
decibel(at)flake(dot)2[13:49]/usr/ports/databases/postgresql80-server/files:38>

Can anyone comment on what the second one does, specifically the
allow_nonpic_in_shlib? As for the first patch, is there any way to make
that FreeBSD specific in the makefile without going to a Makefile.in?
Could that test be done in Makefile.global?
--
Jim C. Nasby, Database Consultant decibel(at)decibel(dot)org
Give your computer some brain candy! www.distributed.net Team #1828

Windows: "Where do you want to go today?"
Linux: "Where do you want to go tomorrow?"
FreeBSD: "Are you guys coming, or what?"

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-07-19 19:11:31 Re: More buildfarm stuff
Previous Message Tom Lane 2005-07-19 18:48:52 Re: Patch to fix plpython on OS X