Re: 4 pgcrypto regressions failures - 1 unsolved

From: Michael Fuhr <mike(at)fuhr(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Kreen <marko(at)l-t(dot)ee>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 4 pgcrypto regressions failures - 1 unsolved
Date: 2005-07-11 15:19:37
Message-ID: 20050711151937.GA77390@winnie.fuhr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, Jul 11, 2005 at 10:39:26AM -0400, Tom Lane wrote:
> Marko Kreen <marko(at)l-t(dot)ee> writes:
> > They won't matter on older OpenSSL, as the macros will recast
> > again. But on 0.9.7e the signature is:
>
> > void DES_ecb3_encrypt(const unsigned char *input, unsigned char *output,
> > DES_key_schedule *ks1,DES_key_schedule *ks2,
> > DES_key_schedule *ks3, int enc);
>
> > so it seems to me that with your patch the warnings will appear
> > on newer OpenSSL. (Confirmed)
>
> Grumble --- you're right. It's probably not worth ifdef'ing the code to
> suppress the warnings on 0.9.7a ...

Hmmm...in 0.9.8 the signature is back to what it was in 0.9.7[a-d]:

void DES_ecb3_encrypt(const_DES_cblock *input, DES_cblock *output,
DES_key_schedule *ks1,DES_key_schedule *ks2,
DES_key_schedule *ks3, int enc);

--
Michael Fuhr
http://www.fuhr.org/~mfuhr/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2005-07-11 15:26:03 Re: 4 pgcrypto regressions failures - 1 unsolved
Previous Message Tom Lane 2005-07-11 15:09:06 Re: 4 pgcrypto regressions failures - 1 unsolved

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2005-07-11 15:26:03 Re: 4 pgcrypto regressions failures - 1 unsolved
Previous Message Tom Lane 2005-07-11 15:09:06 Re: 4 pgcrypto regressions failures - 1 unsolved