Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc
Date: 2005-07-05 19:48:38
Message-ID: 20050705194838.GA30934@l-t.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 05, 2005 at 03:36:06PM -0400, Tom Lane wrote:
> Marko Kreen <marko(at)l-t(dot)ee> writes:
> > On Tue, Jul 05, 2005 at 02:55:07PM -0400, Tom Lane wrote:
> >> Hm ... libpq manages to build code that requires openssl without
> >> needing a generated Makefile, so why do we need it here?
>
> > Now, looking more into it, it indeed does work.
> > But it breaks pgcrypto build for USE_PGXS case.
>
> How exactly?

ifdef USE_PGXS
PGXS = $(shell pg_config --pgxs)
include $(PGXS)
else
.....

The "include $(PGXS)" includes parts that need initialized
local variables, but the variable initializing is the part
that needs settings from main makefiles...

And including Makefile.global twice gives errors.

> > Can I break USE_PGXS?
>
> Nope, that's right out. If we have to use a Makefile.in we will,
> but I'd like to understand why we have to.
>
> > I'd like to eliminate hand-config.
>
> That would be very good. In practice no one is likely to do any manual
> configuration down inside a contrib module ... certainly none of the RPM
> distributions do any such thing.

It was unimportant thus far, but now it's life-or-death ;)

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-07-05 19:58:43 Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc
Previous Message Tom Lane 2005-07-05 19:36:06 Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc