Re: [HACKERS] [PATCH] pgcrypto: pgp_encrypt v3

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] [PATCH] pgcrypto: pgp_encrypt v3
Date: 2005-07-05 09:49:39
Message-ID: 20050705094938.GA5527@l-t.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Tue, Jul 05, 2005 at 10:20:17AM +1000, Neil Conway wrote:
> Bruce Momjian wrote:
> >Your patch has been added to the PostgreSQL unapplied patches list
>
> That is not the latest version of Marko's patch.

Bruce got v3, thats indeed the latest.

Also, http://momjian.postgresql.org/cgi-bin/pgpatches shows v3.

> But in any case, the
> patch is not yet ready for application:
>
> http://archives.postgresql.org/pgsql-patches/2005-07/msg00077.php

Now I did fresh rebuild of CVS and played with it. Result
is that it is only partly my error. It just happens that I did
initdb with option '-E unicode'. Now, can anybody explain the
following difference:

========================================
$ psql -c '\l' template1; psql -c "select 'a\nxxxxxx'::text as
x;" template1
List of databases
Name | Owner | Encoding
--------------------+-------+-----------
contrib_regression | marko | SQL_ASCII
postgres | marko | SQL_ASCII
template0 | marko | SQL_ASCII
template1 | marko | SQL_ASCII
(4 rows)

x
----------
a
xxxxxx
(1 row)
========================================
$ psql -c '\l' template1; psql -c "select 'a\nxxxxxx'::text as
x;" template1
List of databases
Name | Owner | Encoding
--------------------+-------+----------
contrib_regression | marko | UTF8
postgres | marko | UTF8
template0 | marko | UTF8
template1 | marko | UTF8
(4 rows)

x
---
a
xxxxxx
(1 row)

=========================================

I can send new regression test for SQL_ASCII, but it still
would not work for all users.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2005-07-05 13:22:43 timezone changes break windows and cygwin
Previous Message Andreas Pflug 2005-07-05 08:56:07 Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items)

Browse pgsql-patches by date

  From Date Subject
Next Message jtv 2005-07-05 11:26:09 patch: garbage error strings in libpq
Previous Message Andreas Pflug 2005-07-05 08:56:07 Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items)