Re: Tiny patch on print.c of psql

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jean-Paul Argudo <jean-paul(at)argudo(dot)org>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Tiny patch on print.c of psql
Date: 2005-06-14 22:16:34
Message-ID: 200506142216.j5EMGYr06033@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


I have applied your patch, and added the optimization that only leading
spaces are converted to '&nbsp;', as you suggested.

---------------------------------------------------------------------------

Jean-Paul Argudo wrote:
> Hi all,
>
> This is my 1st patch ever in C :-)... I was just borried by a bad psql
> \H html output of an EXPLAIN
>
> because it didnt respected spaces sent from backend like:
>
> -> Sort
> -> Sort
>
> I just remarked in this print.c the case of a white space wasnt handled
> in the function escaping special caracters to HTML codes, so I added it
> replacing a space by special html "&nbsp;" (& n b s p).
>
> So we'll have now:
>
> ->&nbsp;Sort
> &nbsp;&nbsp;->&nbsp;Sort
>
> ... in the html generated
>
> (see example at http://www.pack-solutions.net/~jpargudo/explain.html)
>
> Then, every single space in the html source is replaced by this. The
> source looks ugly, yes, I will look to *only replacing starting spaces*
> of each row of the EXPLAIN, thats will be my 1st patch ever, version 2 :)
>
> So I post this patch only FYI.. I had much fun playing with C a bit :-)
> (yes, I dont code C, just a bit of Perl and Python).
>
> Cheers! Thanks again for such a powerfull release.
>
> --
> Jean-Paul Argudo
> www.PostgreSQLFr.org

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.0 KB

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2005-06-14 22:35:12 Re: indxpath.c refactoring
Previous Message Bruce Momjian 2005-06-14 21:04:06 Re: uptime function to postmaster