From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: indxpath.c refactoring |
Date: | 2005-06-14 22:35:12 |
Message-ID: | 1118788512.3645.63.camel@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Fri, 2005-06-10 at 18:33 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > This simple refactoring patch moves all of the code associated with
> > Partial Index planning into a single file.
>
> Applied with some revisions -
>
> * I put the new predtest.c file into optimizer/util, which seemed a more
> plausible location than /path, and gave it its own header file.
>
> * I thought check_partial_indexes() should stay in indxpath.c; it is an
> application of the theorem-proving module to indexes, not part of the
> prover proper.
>
> * I took the opportunity to rename pred_test() to predicate_implied_by(),
> which seems more clear about what it's doing and in which direction.
>
Many thanks.
> As for the future...
>
> > - redesigning the low level routines to allow them to perform their
> > stuff for both Partial Index and Constraint-based elimination (aka
> > Partitioning...)
>
> The other main entry point should probably be called something like
> predicate_refuted_by?
Will do.
Best Regards, Simon Riggs
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-06-14 23:47:52 | Re: patch between symmetric (add doc) |
Previous Message | Bruce Momjian | 2005-06-14 22:16:34 | Re: Tiny patch on print.c of psql |