| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
| Date: | 2005-06-06 13:35:54 |
| Message-ID: | 200506061335.j56DZs721211@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
> >> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
> >> (But this leak is not serious, because this function is called only once.)
>
> > Does the following patch fix the memory leak you described?
>
> You realize this is a waste of code, no? It's not like the bootstrap
> subprocess frees every single bit of memory it ever allocates, and even
> less like it'd be profitable to try to make it do so ... the memory
> will go away anyway when the subprocess exits.
I guess, but the person reported a leak so I figured I would fix it.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-06-06 13:56:30 | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
| Previous Message | Christopher Kings-Lynne | 2005-06-06 13:33:22 | Re: lastval() |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-06-06 13:56:30 | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
| Previous Message | Christopher Kings-Lynne | 2005-06-06 13:33:22 | Re: lastval() |