Re: pgsql: Fix NUMERIC modulus to properly truncate

Christopher Kings-Lynne wrote:
> Is this a backport?

No, I don't think so. It doesn't seem to be something that enough
people use to risk the change in behavior --- it might break something
that was working. But, if folks want it backported we can do it. It is
only a change to properly do modulus for numeric.

---------------------------------------------------------------------------

>
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Fix NUMERIC modulus to properly truncate division in computation.
> > Division rounding was causing incorrect results. Test case:
> >
> > test=> SELECT 12345678901234567890 % 123;
> > ?column?
> > ----------
> > 78
> > (1 row)
> >
> > Was returning -45.
> >
> > Modified Files:
> > --------------
> > pgsql/src/backend/utils/adt:
> > numeric.c (r1.83 -> r1.84)
> > (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/numeric.c.diff?r1=1.83&r2=1.84)
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 3: if posting/reading through Usenet, please send an appropriate
> > subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> > message can get through to the mailing list cleanly
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073