Re: [BUGS] BUG #1588: pg_autovacuum sleep parameter overflow

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Lionel Bouton <lionel-subscription(at)bouton(dot)name>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #1588: pg_autovacuum sleep parameter overflow
Date: 2005-05-11 17:58:01
Message-ID: 200505111758.j4BHw1v11072@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches


Patch applied and backpatched to 8.0.X.

---------------------------------------------------------------------------

Bruce Momjian wrote:

> Index: contrib/pg_autovacuum/pg_autovacuum.c
> ===================================================================
> RCS file: /cvsroot/pgsql/contrib/pg_autovacuum/pg_autovacuum.c,v
> retrieving revision 1.31
> diff -c -c -r1.31 pg_autovacuum.c
> *** contrib/pg_autovacuum/pg_autovacuum.c 19 Apr 2005 03:35:15 -0000 1.31
> --- contrib/pg_autovacuum/pg_autovacuum.c 11 May 2005 14:43:34 -0000
> ***************
> *** 1749,1755 ****
> fflush(LOGOUTPUT);
> }
>
> ! pg_usleep(sleep_secs * 1000000); /* Larger Pause between outer loops */
>
> gettimeofday(&then, 0); /* Reset time counter */
>
> --- 1749,1764 ----
> fflush(LOGOUTPUT);
> }
>
> ! /* Larger Pause between outer loops */
> ! /*
> ! * pg_usleep() is wrong here because its maximum is ~2000 seconds,
> ! * and we don't need signal interruptability on Win32 here.
> ! */
> ! #ifndef WIN32
> ! sleep(sleep_secs); /* Unix sleep is seconds */
> ! #else
> ! sleep(sleep_secs * 1000); /* Win32 sleep() is milliseconds */
> ! #endif
>
> gettimeofday(&then, 0); /* Reset time counter */
>

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2005-05-11 18:39:26 Re: Missing tables in postgresql 7.2.4
Previous Message Michael Beckstette 2005-05-11 17:55:21 Re: Missing tables in postgresql 7.2.4

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-05-11 18:05:09 Re: Patch that deals with that AtCommit_Portals encounters
Previous Message Andrew Dunstan 2005-05-11 17:16:34 Re: [PATCHES] plperl and pltcl installcheck targets