Re: DELETE ... USING

From: Euler Taveira de Oliveira <eulerto(at)yahoo(dot)com(dot)br>
To: Neil Conway <neilc(at)samurai(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Euler Taveira de Oliveira <eulerto(at)yahoo(dot)com(dot)br>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: DELETE ... USING
Date: 2005-04-06 10:45:34
Message-ID: 20050406104534.53029.qmail@web54604.mail.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi Neil,

> Looking at how to implement this, there is some rather dodgy code in
> warnAutoRange() in parse_relation.c that only emits the notice about
> adding a missing FROM clause entry if the query already has at least
> one
> range table entry in its FROM clause. The idea appears to be to not
> issue warnings about queries like "SELECT foo.*;", but it also means
> we
> don't end up warning about DELETE and UPDATE.
>
> I think the right fix is to remove the "inFromCl" check, and always
> issue a notice. With add_missing_from=true, all these queries are
> rejected anyway, so I think it makes sense to warn about all of them
> when add_missing_from is disabled. Objections?
>
No. That's why I'm thinking now while looking at the code :) Could you
provide a patch?

Euler Taveira de Oliveira
euler[at]yahoo_com_br




Yahoo! Acesso Grátis - Internet rápida e grátis.
Instale o discador agora! http://br.acesso.yahoo.com/

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2005-04-06 10:51:05 Re: DELETE ... USING
Previous Message Dave Page 2005-04-06 10:24:17 Re: 8.0.2 beta announcement??

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-04-06 10:51:05 Re: DELETE ... USING
Previous Message Neil Conway 2005-04-06 08:26:36 Re: avg(int2) and avg(int8) micro-opt