Re: gettext calls in pgport

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: gettext calls in pgport
Date: 2004-10-18 14:43:37
Message-ID: 200410181443.i9IEhbu26983@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> As has previously been pointed out, the strings marked up for gettext
> translation in the pgport library don't work and need to be moved back
> to where they once came from, unless someone wants to add gettext and
> locale setup in pgport. (That might be silly, because in theory locale
> and gettext functions could one day become part of pgport.) I claim
> that pgport is a low-layer library that works on the operating system
> level and should communicate with its callers via error codes.

Error codes seem like a lot more work than it is worth. I vote for
adding gettext support to /port. Also adding error codes duplicates all
the error strings in the call sites.

Added to open items list:

* Add gettext support to src/port

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zeugswetter Andreas DAZ SD 2004-10-18 14:57:48 Re: Open Items
Previous Message Peter Eisentraut 2004-10-18 14:34:29 Re: additional GCC warnings