Re: pgindent vs try/catch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent vs try/catch
Date: 2004-09-12 22:14:15
Message-ID: 200409122214.i8CMEF924424@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
> I had that argument a while ago with Bruce and lost :-) . It does horrible
> things to if/else constructs too. The workaround is to put a comment in the
> block. On the whole I agree with you, though. If I put braces in my program
> it's for a reason, and the indenter shouldn't think it knows better than me.

I have removed the code from pgindent. Now how do we clean up the
try/catch code that got messed up?

The original purpose of that code was to clean up the code we inherited
from Berkeley that had lots of excessive brace blocks and the pgindent
code just remained.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2004-09-12 22:16:27 oid2name
Previous Message Bruce Momjian 2004-09-12 22:01:31 Re: pgxs default installation + various fixes