| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Reini Urban <rurban(at)x-ray(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: APR 1.0 released |
| Date: | 2004-09-09 00:58:43 |
| Message-ID: | 200409090058.i890whO25412@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
>
> Reini Urban wrote:
>
> >
> >
> > FYI: WIN32 is also defined because <windows.h> is included.
> > (/usr/incluse/w32api/windef.h)
> > If you want this or that, do proper nesting, and use #else.
> >
> >
>
> Ugh, yes. A little experimentation shows that __WIN32__ is defined for
> MinGW only, but WIN32 is for both. I wonder how we missed that in
> various places. Maybe we need a little audit of the use of WIN32.
Done, and patch attached and applied. Hopefully at least Cygwin will
compile dirmod.c now. (Most of the patch is consistency
reorganization.) We still need a review of that file.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-09-09 01:03:40 | TRIGGER_DEFERRED_HAS_BEFORE ? |
| Previous Message | Michael Glaesemann | 2004-09-09 00:34:32 | Re: Geometry regression test failure, CVS HEAD, Mac OS/X |