Re: logfile subprocess and Fancy File Functions

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>, Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: logfile subprocess and Fancy File Functions
Date: 2004-07-23 22:21:32
Message-ID: 200407232221.i6NMLW013258@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> I'm pretty much against allowing configuration editing from remote
> >> altogether.
>
> > Why can't they just use COPY to replace the contents of pg_hba.conf now?
>
> If you've write-protected it, that doesn't work.
>
> Also, COPY insists on an absolute path, and if the attacker doesn't know
> the value of $PGDATA or $HOME then he'll have some difficulty doing
> anything much with it. I thought that the handy default of $PGDATA in
> the proposed functions was pretty unwise all by itself --- if they don't
> require absolute paths then that's still another new door we'll be opening.

I think he wanted $PGDATA default so a remote user could find the log
location without a problem. I would prefer to see something specific in
the file name passed to identify PGDATA, but I don't have a problem with
the substitution. Thinking we have security because they can't guess
pgdata seems like security through obscurity to me.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-07-23 22:25:05 Re: logfile subprocess and Fancy File Functions
Previous Message Bruce Momjian 2004-07-23 22:20:05 Re: logfile subprocess and Fancy File Functions