Re: Type typo in parameter of pgsql function

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Michael Glaesemann <grzm(at)myrealbox(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Type typo in parameter of pgsql function
Date: 2004-07-11 23:27:00
Message-ID: 200407112327.i6BNR1o29881@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied. Thanks. Your documentation changes can be viewed in
five minutes using links at the bottom of the developer's page,
http://developer.postgresql.org/index.php.

---------------------------------------------------------------------------

Michael Glaesemann wrote:
> Hello all
>
> This patch fixes a small error in the Porting PL/SQL to PL/pgSQL
> section where a instr function parameter is mistyped as varchar. It
> works properly when changed to integer.
>
> This is only my second patch. I generated it using cvs diff -c
> filename. If I've bungled the format, please let me know.
>
> Michael Glaesemann
> grzm myrealbox com
>
> Index: plpgsql.sgml
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/plpgsql.sgml,v
> retrieving revision 1.39
> diff -c -r1.39 plpgsql.sgml
> *** plpgsql.sgml 4 Jul 2004 02:48:52 -0000 1.39
> --- plpgsql.sgml 5 Jul 2004 01:12:31 -0000
> ***************
> *** 2957,2963 ****
> $$ LANGUAGE plpgsql;
>
>
> ! CREATE FUNCTION instr(varchar, varchar, varchar) RETURNS integer AS $$
> DECLARE
> string ALIAS FOR $1;
> string_to_search ALIAS FOR $2;
> --- 2957,2963 ----
> $$ LANGUAGE plpgsql;
>
>
> ! CREATE FUNCTION instr(varchar, varchar, integer) RETURNS integer AS $$
> DECLARE
> string ALIAS FOR $1;
> string_to_search ALIAS FOR $2;
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-07-11 23:29:45 Re: Updated ALTER TABLE ... SET TABLESPACE patch
Previous Message Bruce Momjian 2004-07-11 23:23:51 Re: Example for create function using argument names