Re: Cancel/Kill backend functions

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Cancel/Kill backend functions
Date: 2004-05-27 18:30:33
Message-ID: 20040527183033.GA3107@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, May 27, 2004 at 08:08:34PM +0200, Magnus Hagander wrote:

> >Magnus Hagander wrote:
> >> Okay, here is an updated patch. now uses IsBackendPid(), which is
> >> closely modeled (read cut-and-pasted) from
> >> TransactionIdIsInProgress().

I wonder what can happen if a backend passes the IsBackendPid() test and
terminates just before the kill() signal? It should be pretty unlikely
but you could signal the wrong process ... shouldn't the SInvalLock be
held throughout the whole operation?

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"El número de instalaciones de UNIX se ha elevado a 10,
y se espera que este número aumente" (UPM, 1972)

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2004-05-27 18:35:28 Re: Cancel/Kill backend functions
Previous Message Magnus Hagander 2004-05-27 18:08:34 Re: Cancel/Kill backend functions