Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Date: 2004-05-19 19:39:05
Message-ID: 200405191939.i4JJd5w11094@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I moved the find_my_exec calls to the locations you mentioned in
> > both postgres.c and postmaster.c and remove it from main.c.  I tested
> > the elog and it worked.
> 
> You omitted get_pkglib_path() from the postmaster case; was that
> intentional?

Got it later.  Thanks.

> Also, in the non-exec case it seems unnecessary and possibly unsafe to
> repeat this computation in a backend.  It should inherit the settings
> from the postmaster via fork(), I'd think.  So possibly
> 
> #ifndef EXEC_BACKEND
> 	if (!IsUnderPostmaster)
> #endif
> 	{
> 		find_my_exec(...);
> 		get_pkglib_path(...);
> 	}

Thanks.  It originally was as below and I forgot about that.  It now is:

    if (my_exec_path[0] == '\0' && find_my_exec(argv[0], my_exec_path) < 0)

The issue is that fork/exec will need to set it too.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-05-19 19:39:27
Subject: pgsql-server/src/backend/tcop postgres.c
Previous:From: Tom LaneDate: 2004-05-19 19:11:33
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

pgsql-patches by date

Next:From: Tom LaneDate: 2004-05-19 20:01:01
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous:From: Tom LaneDate: 2004-05-19 19:11:33
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group