From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p |
Date: | 2004-05-19 19:39:05 |
Message-ID: | 200405191939.i4JJd5w11094@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I moved the find_my_exec calls to the locations you mentioned in
> > both postgres.c and postmaster.c and remove it from main.c. I tested
> > the elog and it worked.
>
> You omitted get_pkglib_path() from the postmaster case; was that
> intentional?
Got it later. Thanks.
> Also, in the non-exec case it seems unnecessary and possibly unsafe to
> repeat this computation in a backend. It should inherit the settings
> from the postmaster via fork(), I'd think. So possibly
>
> #ifndef EXEC_BACKEND
> if (!IsUnderPostmaster)
> #endif
> {
> find_my_exec(...);
> get_pkglib_path(...);
> }
Thanks. It originally was as below and I forgot about that. It now is:
if (my_exec_path[0] == '\0' && find_my_exec(argv[0], my_exec_path) < 0)
The issue is that fork/exec will need to set it too.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-05-19 19:39:27 | pgsql-server/src/backend/tcop postgres.c |
Previous Message | Tom Lane | 2004-05-19 19:11:33 | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-05-19 20:01:01 | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p |
Previous Message | Tom Lane | 2004-05-19 19:11:33 | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p |