Re: mingw configure failure detection

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: mingw configure failure detection
Date: 2004-05-13 22:59:31
Message-ID: 200405132259.i4DMxVB06125@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Andrew Dunstan wrote:
> Peter Eisentraut wrote:
>
> >Andrew Dunstan wrote:
> >
> >
> >>The patch as applied is totally broken - the tests have to be run by
> >>config.status after it has actually tried to make the links, which is
> >>why I used AC_CONFIG_COMMANDS.
> >>
> >>
> >
> >Additional note: Instead of listing the files explicitly, just use
> >$CONFIG_LINKS, which contains the list of files.
> >
> >
> >
> >
>
> Well, yes, except that each entry there is in the form
> linkname:targetname - we'd have to have extra code to split them up.
> Something like:
>
> for ac_file in : $CONFIG_LINKS; do test "x$ac_file" = x: && continue
> linktry=`echo "$ac_file" | sed 's,:.*,,'`
> test ......
> done

OK, attached patch applied.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 3.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-05-13 23:02:17 Re: database errors
Previous Message Andrew Dunstan 2004-05-13 22:57:46 Re: Bringing PostgreSQL torwards the standard regarding

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Dave Page 2004-05-14 07:22:50 Re: [HACKERS] pg_autovacuum Win32 service patch #2
Previous Message Matthew T. O'Connor 2004-05-13 20:39:33 Re: [HACKERS] pg_autovacuum Win32 service patch #2

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-13 23:06:15 Re: [HACKERS] threads stuff/UnixWare
Previous Message Bruce Momjian 2004-05-13 22:46:13 Reorganize backend handling of executable names