Re: mingw configure failure detection

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: mingw configure failure detection
Date: 2004-05-13 01:29:25
Message-ID: 200405130129.i4D1TPQ17733@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches


Adjusted attached patch applied. Thanks.

I didn't change 'test -e' because 'test -h' doesn't work (is symlink
test on my platform). test -f actually works on symlinks too in MinGW,
strangely enough. Anyway, the code is only run on MinGW so we don't
have to worry about other platforms. I added a comment explaining it
works.

I got rid of the AC_CONFIG_COMMANDS and just do the for/test loop in the
shell code directly. AC_CONFIG_COMMANDS wouldn't allow me to call
AC_MSG_WARN.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Andrew Dunstan wrote:
> > This patch for configure.in detects the link failures in MINGW that I
> > and others have seen and warns the user they have to fix it up.
>
> I continue to object to these sort of patches if no one wants to bother
> to contact the mingw maintainers about this problem. Maybe they have a
> better fix available?
>
> Btw. test -e is not portable. And please use AC_MSG_WARN instead of
> "echo".
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-13 01:31:03 Re: mingw configure failure detection
Previous Message Marc G. Fournier 2004-05-13 01:14:33 Re: UnixWare/Threads stuff [repost from March]

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Claudio Natoli 2004-05-13 01:29:37 Re: Runtime Problems
Previous Message Claudio Natoli 2004-05-13 01:26:41 Re: Runtime Problems

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-13 01:31:03 Re: mingw configure failure detection
Previous Message Neil Conway 2004-05-13 00:07:20 Re: SQLState