From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: FW: Timezone library |
Date: | 2004-05-01 03:12:33 |
Message-ID: | 200405010312.i413CXO29864@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > I think it would be better to put it under one of the generic
> > subdirectories, such as src/utils/timezone. We may have to add
> > additional libraries of this kind in the future, and it would be better
> > to have them grouped somehow.
>
> The closest precedent we have at the moment is src/backend/regex, which
> is a fairly large library that we imported lock-stock-and-barrel.
> However, this precedent wouldn't hold if the code needs to be usable
> from non-backend code. ecpg seems to want to use the tz code ...
I asked if ecpg should use the same timezone database as the server and
someone said it could just use the local one.
I was concerned ecpg would be reading structure and had to assume the
timezones split up the same way as the server.
> Right at the moment I am thinking we may end up keeping only about one
> file out of the existing src/timezone import, so maybe it doesn't need
> a whole subdirectory anyway?
Not sure, but it is easy to move.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-05-01 03:18:02 | Re: win32 build and test issues |
Previous Message | Tom Lane | 2004-05-01 03:09:15 | Re: FW: Timezone library |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-05-01 03:18:02 | Re: win32 build and test issues |
Previous Message | Bruce Momjian | 2004-05-01 03:09:48 | Re: win32 build and test issues |