pg_autovacuum reltuples bug

From: "Jim C(dot) Nasby" <jim(at)nasby(dot)net>
To: pgsql-bugs(at)postgresql(dot)org
Subject: pg_autovacuum reltuples bug
Date: 2004-04-27 19:05:29
Message-ID: 20040427190529.GL41429@nasby.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

There's a bug in pg_autovacuum that makes it vacuum large tables way to
frequently.

ogr=# select reltuples from pg_class where relname='ogr_summary';
reltuples
-------------
2.64411e+07
(1 row)

[2004-04-27 02:03:08 PM] table name: ogr."public"."ogr_results"
[2004-04-27 02:03:08 PM] relid: 615097; relisshared: 0
[2004-04-27 02:03:08 PM] reltuples: 7; relpages: 519951
[2004-04-27 02:03:08 PM] curr_analyze_count: 9904180; cur_delete_count: 168282
[2004-04-27 02:03:08 PM] ins_at_last_analyze: 9904180; del_at_last_vacuum: 168282
[2004-04-27 02:03:08 PM] insert_threshold: 507; delete_threshold 1014
[2004-04-27 02:03:08 PM] added table: ogr."public"."ogr_results"

I suspect the issue is on line 121:
new_tbl->reltuples = atoi(PQgetvalue(res, row, PQfnumber(res, "reltuples")));

I'm not a C coder, but doesn't atoi just take a text value and convert
it to an int? Shouldn't all the stats counters be stored as reals?
--
Jim C. Nasby, Database Consultant jim(at)nasby(dot)net
Member: Triangle Fraternity, Sports Car Club of America
Give your computer some brain candy! www.distributed.net Team #1828

Windows: "Where do you want to go today?"
Linux: "Where do you want to go tomorrow?"
FreeBSD: "Are you guys coming, or what?"

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PostgreSQL Bugs List 2004-04-27 19:32:21 BUG #1143: comments don't get propagated
Previous Message Alvaro Herrera 2004-04-27 18:57:14 Re: [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5