Re: installdir patch for win32

Andrew Dunstan wrote:
> >Every "#ifdef WIN32" I see reduces my opinion of the quality of work
> >being done for this port.
> >
> >
> >
>
> Tom,
>
> I think in defense of Claudio and company, it should be noted that there
> has been a desire not to disturb existing functionality more than
> necessary, and that has led fairly obviously to use of #ifdef with some
> liberality.

Agreed. When we have issues with special socket restriction in signal
handlers on the platform, and things like that, there isn't much we can
do except #ifdef WIN32. I have been surprised how few #ifdef's we have
needed for this platform. I do like to see a comment at the top of
WIN32-specific code so we know what OS limtiation we are working around,
and I think that has been done.

In fact, here is a count of WIN32 references in each file. You will
find the backend has very few references, with most in interfaces or
/bin, which makes sense.

---------------------------------------------------------------------------

1 ./backend/access/transam/slru.c
1 ./backend/access/transam/xlog.c
1 ./backend/commands/copy.c
4 ./backend/commands/dbcommands.c
2 ./backend/libpq/md5.c
1 ./backend/libpq/pqcomm.c
3 ./backend/libpq/pqsignal.c
8 ./backend/main/main.c
5 ./backend/postmaster/pgstat.c
13 ./backend/postmaster/postmaster.c
6 ./backend/utils/fmgr/dfmgr.c
3 ./backend/utils/init/findbe.c
1 ./backend/utils/init/miscinit.c
4 ./backend/postgres
12 ./bin/initdb/initdb.c
1 ./bin/pg_resetxlog/pg_resetxlog.c
1 ./bin/psql/bcc32.mak
10 ./bin/psql/command.c
6 ./bin/psql/common.c
3 ./bin/psql/common.h
2 ./bin/psql/copy.c
5 ./bin/psql/describe.c
8 ./bin/psql/help.c
1 ./bin/psql/input.c
4 ./bin/psql/mainloop.c
1 ./bin/psql/mainloop.h
1 ./bin/psql/mbprint.c
4 ./bin/psql/print.c
1 ./bin/psql/prompt.c
7 ./bin/psql/startup.c
1 ./bin/psql/win32.mak
1 ./bin/scripts/common.c
4 ./bin/scripts/print.c
1 ./bin/scripts/mbprint.c
4 ./include/c.h
1 ./include/miscadmin.h
1 ./include/pg_config.h.win32
3 ./include/pg_config_manual.h
5 ./include/port.h
1 ./include/rusagestub.h
1 ./include/libpq/hba.h
3 ./include/libpq/pqcomm.h
3 ./include/libpq/pqsignal.h
1 ./include/port/win32.h
1 ./include/utils/elog.h
1 ./interfaces/ecpg/include/sqlca.h
1 ./interfaces/ecpg/pgtypeslib/dt.h
2 ./interfaces/libpgtcl/win32.mak
1 ./interfaces/libpq/bcc32.mak
2 ./interfaces/libpq/fe-auth.c
2 ./interfaces/libpq/fe-exec.c
1 ./interfaces/libpq/fe-lobj.c
1 ./interfaces/libpq/fe-misc.c
8 ./interfaces/libpq/fe-print.c
1 ./interfaces/libpq/fe-protocol2.c
1 ./interfaces/libpq/fe-protocol3.c
6 ./interfaces/libpq/fe-connect.c
8 ./interfaces/libpq/fe-secure.c
2 ./interfaces/libpq/md5.c
1 ./interfaces/libpq/libpqdll.c
2 ./interfaces/libpq/win32.c
1 ./interfaces/libpq/pqexpbuffer.c
1 ./interfaces/libpq/pqsignal.c
1 ./interfaces/libpq/win32.mak
3 ./interfaces/libpq/libpq-int.h
2 ./interfaces/libpq/noblock.c
4 ./interfaces/libpq/path.c
2 ./interfaces/libpq/thread.c
4 ./interfaces/libpq/libpq.so.3.2
4 ./interfaces/libpq/libpq.so.3
4 ./interfaces/libpq/libpq.so
1 ./port/crypt.c
3 ./port/dirmod.c
1 ./port/getrusage.c
2 ./port/noblock.c
4 ./port/path.c
1 ./port/pgsleep.c
4 ./port/sprompt.c
2 ./port/thread.c
1 ./port/open.c
2 ./utils/dllinit.c

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073