Re: fork/exec patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fork/exec patch
Date: 2003-12-13 15:46:06
Message-ID: 200312131546.hBDFk6h08312@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches


Let me provide a summary of this patch because I reviewed the first
version.

The patch basically is a slight rearrangement of the code to allow
fork/exec on Unix, with the ultimate goal of doing CreateProcess on
Win32. The changes are:

o Write out postmaster global variables and per-backend
variables to be read by the exec'ed backend

o Mark some static variables as global when exec is used so
then can be dumped from postmaster.c, marked NON_EXEC_STATIC

o Remove value passing with -p now that we have per-backend
file

o Move some pointer storage out of shared memory for easier
dumping.

o Modified pgsql_temp directory cleanup to handle per-database
directories and the backend exec directory under datadir.

Let me add that Claudio is doing a fantastic job on this. The changes
are minimal and clean. I think the writing of a per-backend temp file
has allowed this patch to be smaller than it might have been.

---------------------------------------------------------------------------

Claudio Natoli wrote:
>
> This patch is the next step towards (re)allowing fork/exec.
>
> Bruce, I've cleaned up the parts we discussed, and, pending objections from
> anyone else, it is ready for application to HEAD.
>
> Cheers,
> Claudio
>
> ---
> Certain disclaimers and policies apply to all email sent from Memetrics.
> For the full text of these disclaimers and policies see
> <a
> href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
> ailpolicy.html</a>
>
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Succa 2003-12-13 17:25:22 Re: Read-only column
Previous Message Doug McNaught 2003-12-13 15:24:16 Re: Read-only column

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Neil Conway 2003-12-14 21:06:26 Re: fork/exec patch
Previous Message Claudio Natoli 2003-12-13 07:24:28 fork/exec patch

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2003-12-14 00:01:10 Re: minor SGML improvements
Previous Message Claudio Natoli 2003-12-13 07:24:28 fork/exec patch