Re: PATCH: Uninitialized variable usage in contrib/pg_autovacuum

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Craig Boston <craig(at)qbrtr(dot)gank(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org
Subject: Re: PATCH: Uninitialized variable usage in contrib/pg_autovacuum
Date: 2003-12-01 23:12:50
Message-ID: 200312012312.hB1NCo212231@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches


Patch applied. Thanks.

---------------------------------------------------------------------------

Craig Boston wrote:
> Sorry about the cross-post -- I'm not 100% sure which list this should be sent
> to.
>
> I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is
> not initialized if a log file is not specified on the command line. This
> causes an immediate segfault on systems that fill allocated memory with some
> value other than zero (my FreeBSD machine uses 0xD0).
>
> Several crashes later I discovered that args->user, password, host, and port
> are also used without being initialized.
>
> This doesn't appear to be fixed in CVS and I came up empty on a mailing list
> search -- hope it hasn't been reported already.
>
> Attached is a quick patch that fixes the problem.
>
> --
> Craig

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2003-12-01 23:14:11 Re: PATCH: Uninitialized variable usage in contrib/pg_autovacuum
Previous Message SZUCS Gábor 2003-12-01 18:42:18 Re: unix_socket_directory vs pg_ctl?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-12-01 23:14:11 Re: PATCH: Uninitialized variable usage in contrib/pg_autovacuum
Previous Message Bruce Momjian 2003-12-01 23:11:53 Re: YA Cygwin DLLIMPORT patch