Re: Autocomplete <TAB> on Postgres7.4beta5 not working?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gaetano Mendola <mendola(at)bigfoot(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org, Ian Barwick <barwick(at)gmx(dot)net>
Subject: Re: Autocomplete <TAB> on Postgres7.4beta5 not working?
Date: 2003-10-28 22:05:22
Message-ID: 200310282205.h9SM5Ml21332@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Tom Lane wrote:
> This appears to have been a deliberate change:
>
> 2003-03-27 11:45 momjian
>
> * src/bin/psql/tab-complete.c: Attached are two patches for psql's
> tab-completion.c.
> [snip]
>
> Note that tables, indexes, views and sequences relations in the
> 'pg_catalog' namespace are excluded even though they are in the
> current search path. I found not doing this produced annoying
> behaviour when expanding names beginning with 'p'. People who work
> with system tables a lot may not like this though; I can look for
> another solution if necessary.
>
> Ian Barwick
>
> AFAICT there was no discussion about this issue when the patch was
> proposed and applied. But now that the point is raised I have to say
> that I don't like this change. I don't think system catalogs should be
> excluded from tab completion. They never were before 7.4, and I have
> not seen anyone complaining about that, other than Ian.
>
> Comments anyone?

No one commented on it so it was applied --- now that we have two people
who don't like it, seems we should back it out.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jon Jensen 2003-10-28 22:07:48 Re: [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not
Previous Message Tom Lane 2003-10-28 21:48:59 Re: Autocomplete <TAB> on Postgres7.4beta5 not working?

Browse pgsql-hackers by date

  From Date Subject
Next Message Jon Jensen 2003-10-28 22:07:48 Re: [BUGS] Autocomplete <TAB> on Postgres7.4beta5 not
Previous Message Tom Lane 2003-10-28 21:48:59 Re: Autocomplete <TAB> on Postgres7.4beta5 not working?