Re: Minor irritant with comment parsing in a function (SQL) body

Peter has fixed this in CVS. Thanks for the report.

---------------------------------------------------------------------------

Richard Huxton wrote:
> Versions: 7.3, 7.4beta (not latest)
> Applies to SQL functions, but not apparently to plpgsql (because of the
> different parser, I presume).
>
> This is really a "doctor it hurts when I..." thing - the fact that I've never
> come across it before must mean it's pretty hard to trigger.
>
> The first version of this function compiles fine, the second doesn't.
>
> CREATE OR REPLACE FUNCTION zzz_test () RETURNS text AS '
> SELECT ''hello world''::text;
> -- SELECT ''goodbye world''
> ' LANGUAGE 'SQL';
>
> CREATE OR REPLACE FUNCTION zzz_test () RETURNS text AS '
> SELECT ''hello world''
> -- SELECT ''goodbye world''
> ::text;
> ' LANGUAGE 'SQL';
>
> ERROR: parser: unterminated quoted string at or near "'hello world'
> -- SELECT 'goodbye world'
> ::text;
> "
>
> It took forever to find a simple reproducible example, but the rules seem to
> be:
> 1. You must have quoting at the end of both adjacent lines
> 2. Both lines must be within a single SQL statement.
> 3. You must use the -- comment, not /* ... */
>
> Originally spotted with a formulation like:
> AND type1 = ''A''
> AND type2 = ''B''
> ...
> I commented one test and got an error message.
>
> --
> Richard Huxton
> Archonet Ltd
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073