Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-05 14:30:44
Message-ID: 200310051430.h95EUi324729@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut wrote:
> Tom Lane writes:
>
> > I would prefer to see the log entries look like
> >
> > LOG: query: select * from pg_class;
> > LOG: duration: nn.nnn msec
>
> I'm not fond of the abbrevation "msec" or even "msecs". The official
> abbreviation is "ms".

Yep. Someone suggested "msec" in their example, so I used that, but I
like "ms" better too:

LOG: duration: 0.950 ms; select 1;
LOG: duration: 0.269 ms; set log_min_duration_statement = 1;

Patch attached.

> Btw., I was wondering, are we kidding ourselves when we display
> microsecond precision to the user? What accuracy do these measurements
> have in respect to what they are actually supposed to measure?

Not sure. I think the microsecond stuff is accurate to some degree, but
not sure how much. I think the tick is 10ms, but I thought the timing
was much more accurate than that.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 7.0 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Cornelia Boenigk 2003-10-05 14:55:52 What values does PQstatus return
Previous Message Bruce Momjian 2003-10-05 13:34:54 Re: Open 7.4 items