From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Reorganization of spinlock defines |
Date: | 2003-09-12 04:39:00 |
Message-ID: | 200309120439.h8C4d0O19572@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
New patch attached.
---------------------------------------------------------------------------
Bruce Momjian wrote:
> Prompted by confusion over Itanium/Opterion, I have written a patch to
> improve the way we define spinlocks for platforms and cpu's. It
> basically decouples the OS from the CPU spinlock code. In almost all
> cases, the spinlock code cares only about the compiler and CPU, not the
> OS.
>
> The patch:
>
> o defines HAS_TEST_AND_SET inside each spinlock routine, not in
> platform-specific files
> o moves slock_t defines into the spinlock routines
> o remove NEED_{CPU}_TAS_ASM define because it is no longer needed
> o reports a compile error if spinlocks are not defined
> o adds a configure option --without-spinlocks to allow
> non-spinlock compiles
>
> Looking at the patch, I realize this is how we should have done it all
> along.
>
> It would be nice to report the lack of spinlocks in configure, rather
> than during the compile, but I can't compile s_lock.h and test for
> HAS_TEST_AND_SET until configure completes.
>
> I plan to apply this to 7.4.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 37.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-09-12 04:59:22 | Re: [HACKERS] Reorganization of spinlock defines |
Previous Message | Tom Lane | 2003-09-12 04:33:59 | Heads up: beta3 planned for Monday |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-09-12 04:59:22 | Re: [HACKERS] Reorganization of spinlock defines |
Previous Message | Bruce Momjian | 2003-09-12 04:18:53 | Re: [PATCHES] Reorganization of spinlock defines |