Re: [HACKERS] Reorganization of spinlock defines

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Reorganization of spinlock defines
Date: 2003-09-12 04:14:20
Message-ID: 200309120414.h8C4EKS06891@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Marc G. Fournier wrote:
>
> On Thu, 11 Sep 2003, Bruce Momjian wrote:
>
> > I just learned from Larry that Unixware defines intel as i386, not
> > __i386 or __i386__, at least of the native SCO compiler that he uses.
>
> could we put something in the various port files to standardize this? ie.
> in unixware.h, add somethinglike:
>
> #ifdef i386
> #define __i386__
> #endif
>
> just so that 'special cases' are centralized in the ports file, and the
> mainstream code doesn't have:
>
> #if defined(i386) || defined(__i386) || defined(__i386__)

Yep, that's what Tom wants and I am doing that now. I sent a patch to
Larry for testing.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2003-09-12 04:14:22 Re: [PATCHES] Reorganization of spinlock defines
Previous Message Marc G. Fournier 2003-09-12 04:10:57 Re: [HACKERS] Reorganization of spinlock defines

Browse pgsql-patches by date

  From Date Subject
Next Message Marc G. Fournier 2003-09-12 04:14:22 Re: [PATCHES] Reorganization of spinlock defines
Previous Message Marc G. Fournier 2003-09-12 04:10:57 Re: [HACKERS] Reorganization of spinlock defines