Re: [PATCHES] Reorganization of spinlock defines

From: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Reorganization of spinlock defines
Date: 2003-09-12 04:14:22
Message-ID: 20030912011224.Q57860@ganymede.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Fri, 12 Sep 2003, Bruce Momjian wrote:

> Marc G. Fournier wrote:
> >
> >
> > On Thu, 11 Sep 2003, Bruce Momjian wrote:
> >
> > > Well, the problem was that we defined HAS_TEST_AND_SET inside the ports.
> > > I guess we could splatter a test for Itanium and Opterion in every port
> > > that could possibly use it, but then again, if we fall back to not
> > > finding it for some reason, we don't get a report because we silently
> > > fall back to semaphores. That's what has me worried, that if we don't
> > > do it, we will not know what platforms really aren't working properly.
> >
> > >From what I understand, "not working properly" means slow, not broken, no?
> > Which means ppl could submit a problem report and it could be fixed for
> > v7.4.1 ... its not so much 'not working properly' as it is 'not optimal
> > performance' ...
>
> Right, though I am not sure people will know _slow_ configuration vs.
> PostgreSQL is slow.

No, but definitely something for those discussion performance to add
to their checklist :)

BTW, post-compile, running system ... how do you check this? Or can you?

For instance, having a checklist, of sorts, that ppl can go through when
trying to investigate performance issues could include stuff like:

check swap usage (albeit obvious to alot of ppl, not to all)
check disk usage using iostat
check spinlocks in use using ... ??

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-09-12 04:17:22 Re: [PATCHES] Reorganization of spinlock defines
Previous Message Bruce Momjian 2003-09-12 04:14:20 Re: [HACKERS] Reorganization of spinlock defines

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-09-12 04:17:22 Re: [PATCHES] Reorganization of spinlock defines
Previous Message Bruce Momjian 2003-09-12 04:14:20 Re: [HACKERS] Reorganization of spinlock defines