Re: Another small bug (pg_autovacuum)

Patch applied. You might want to look at pg_dump/dumputils.c::fmtId()
for a function that does smart quoting.

---------------------------------------------------------------------------

Matthew T. O'Connor wrote:
> On Wed, 2003-09-10 at 15:57, Bruce Momjian wrote:
> > I assume the attached patch is what you want done to fix this. Applied.
> >
> > It quotes table names for vacuum and analyze, and uppercases the
> > keywords for clarity.
>
> Yeah, this is basically what I meant, sorry I didn't get to it quicker.
>
> However, I tested it out a little and the patch you made doesn't work
> because it produces commands like:
>
> VACUUM ANALYZE "public.FooBar"
>
> Which doesn't work, so I made my own patch that creates commands like:
>
> VACUUM ANALYZE "public"."FooBar"
>
> This allows for mixed case schema names as well as tables.
>
> Adam, can you please give this a test as you are the person who caught
> the bug in the first place.
>
> Thanks,
>
> Matthew T. O'Connor
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073