Re: Minor build fix for CVS HEAD

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: John Gray <jgray(at)azuli(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Minor build fix for CVS HEAD
Date: 2003-08-13 03:12:09
Message-ID: 200308130312.h7D3C9O02962@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Thanks. Change made.

---------------------------------------------------------------------------

John Gray wrote:
> I'm quite fond of doing VPATH builds, i.e. building outside the source
> tree. This also catches lots of little Makefile bugs, so here's a small
> patch for one of them (replacing an explicit reference to thread.c with
> a reference to it as the first prerequsite of the rule makes make look
> for it in the place where it was found (the source tree) rather than in
> the build tree. (using GNU make 3.79.1)
> Regards
>
> John (on holiday for two weeks so unlikely to be able to comment further
> on it)
>
>
> Index: src/port/Makefile
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/port/Makefile,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile
> --- src/port/Makefile 8 Aug 2003 02:55:08 -0000 1.5
> +++ src/port/Makefile 9 Aug 2003 19:42:53 -0000
> @@ -23,7 +23,7 @@
> $(AR) crs $@ $^
>
> thread.o: thread.c
> - $(CC) $(CFLAGS) $(CPPFLAGS) $(THREAD_CFLAGS) -c thread.c
> + $(CC) $(CFLAGS) $(CPPFLAGS) $(THREAD_CFLAGS) -c $<
>
> clean distclean maintainer-clean:
> rm -f libpgport.a $(LIBOBJS)
>
> --
> John Gray <jgray(at)azuli(dot)co(dot)uk>
> Azuli IT
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Andriy Tkachuk 2003-08-13 07:42:27 psql's HISTSIZE from .psqlrc do not want to be set
Previous Message John Gray 2003-08-12 22:49:29 Minor build fix for CVS HEAD