Re: Postgresql.conf, initdb patch

On Tuesday 01 July 2003 05:39, Peter Eisentraut wrote:
> Josh Berkus writes:
> > initdb.patch, written by Shridhar, patches initdb so that the LC_*
> > localization variables are inserted into postgresql.conf at the point
> > commented "#LC VARS GO HERE!"
>
> It's pretty pointless to use
>
> cat $file | sed 's/.../'
>
> because sed can open files perfectly well:
>
> sed 's/.../' $file
>
> You should clean up the temp files in exit_nicely(), because if someone or
> something aborts initdb in the middle, then the trap will at least have a
> better chance to remove the files.

Argh. That was me who did that patch and it was not good.

Anyway attached is the patch

* Which uses sed correctly
* and get rid of temp files at all.

Hopefully this will be good enough.

Shridhar