From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Rod Taylor <rbt(at)rbt(dot)ca> |
Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: UPDATE ... SET <col> = DEFAULT |
Date: | 2003-06-25 04:19:37 |
Message-ID: | 200306250419.h5P4JbK13552@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Patch applied. Thanks.
---------------------------------------------------------------------------
Rod Taylor wrote:
-- Start of PGP signed section.
> Modify rewriteTargetList() to deal with a SetToDefault node
> InsertDefault renamed.
>
> Teach updateTargetListEntry() to use the columns type rather than
> calling exprType for it, since SetToDefault does not have a type but is
> stored in (TargetEntry *)->expr
>
> Remove special case in insert code. Let the default request flow
> through the same as the update case.
>
>
> On Thu, 2003-06-05 at 16:45, Tom Lane wrote:
> > Rod Taylor <rbt(at)rbt(dot)ca> writes:
> > > It would seem a new primnode (change InsertDef into SetDefault or
> > > similar) will be required with some executor logic.
> >
> > It is not the executor's business to know about defaults. The rewriter
> > is the place where defaults get inserted - see rewriteTargetList().
> >
> > Note that default NULL will have to be treated a little differently from
> > what we do for INSERT, since the, um, default behavior of UPDATE is to
> > preserve columns rather than replace 'em with nulls.
> >
> > regards, tom lane
>
> --
> Rod Taylor <rbt(at)rbt(dot)ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc
[ Attachment, skipping... ]
-- End of PGP section, PGP failed!
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-06-25 04:32:34 | Fix up JOIN .. USING with domains |
Previous Message | Bruce Momjian | 2003-06-25 04:09:22 | Re: Ensure all implicit constraints are named |